flume-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From esam...@apache.org
Subject svn commit: r1162241 - /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
Date Fri, 26 Aug 2011 20:35:46 GMT
Author: esammer
Date: Fri Aug 26 20:35:46 2011
New Revision: 1162241

URL: http://svn.apache.org/viewvc?rev=1162241&view=rev
Log:
- Added a note about returning null sources from SourceFactory. Applies to sinks as well.

Modified:
    incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java

Modified: incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
URL: http://svn.apache.org/viewvc/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java?rev=1162241&r1=1162240&r2=1162241&view=diff
==============================================================================
--- incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
(original)
+++ incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
Fri Aug 26 20:35:46 2011
@@ -52,6 +52,7 @@ public class DefaultSourceFactory implem
 
     logger.debug("Creating instance of source {}", name);
 
+    /* FIXME: Is returning null really a good idea? Should we just panic? */
     if (!sourceRegistry.containsKey(name)) {
       return null;
     }



Mime
View raw message