flink-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rong Rong <walter...@gmail.com>
Subject Re: is it OK to PR just for code comment errors?
Date Thu, 31 May 2018 14:52:37 GMT
Hi Makeyang,

It is definitely OK to open a PR for correcting code comment errors.
Especially for the ones that are misleading or provide incorrect
information to users.

I am not sure if it is required if only for a one-liner change, but please
file a JIRA ticket for the code comment error as well.

Thanks,
Rong

On Thu, May 31, 2018 at 2:40 AM, makeyang <riverbuilding@hotmail.com> wrote:

> I am not sure if it is OK to PR just for code comment errors since I found
> there is one when I am reading code
>
>
>
> --
> Sent from: http://apache-flink-user-mailing-list-archive.2336050.
> n4.nabble.com/
>

Mime
View raw message