Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 56925200C28 for ; Mon, 13 Mar 2017 14:33:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 55342160B6C; Mon, 13 Mar 2017 13:33:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7AB04160B60 for ; Mon, 13 Mar 2017 14:33:41 +0100 (CET) Received: (qmail 31073 invoked by uid 500); 13 Mar 2017 13:33:39 -0000 Mailing-List: contact user-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@flink.apache.org Delivered-To: mailing list user@flink.apache.org Received: (qmail 30485 invoked by uid 99); 13 Mar 2017 13:33:38 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 13:33:38 +0000 Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id BD7471A0193; Mon, 13 Mar 2017 13:33:37 +0000 (UTC) Received: by mail-io0-f174.google.com with SMTP id f84so82488845ioj.0; Mon, 13 Mar 2017 06:33:37 -0700 (PDT) X-Gm-Message-State: AMke39kIbkMztpfrY6crGkwUNqS2Orm4xLDaYOMH51AEUYvevMVPjK/p0DPjYyzDVgdBDdXKrKnOmZjb9/54Gg== X-Received: by 10.107.202.135 with SMTP id a129mr27435650iog.129.1489412016962; Mon, 13 Mar 2017 06:33:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.163.2 with HTTP; Mon, 13 Mar 2017 06:33:16 -0700 (PDT) In-Reply-To: References: From: Robert Metzger Date: Mon, 13 Mar 2017 14:33:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Frontend classpath issue To: "user@flink.apache.org" Cc: "dev@flink.apache.org" Content-Type: multipart/alternative; boundary=94eb2c0bd0f8321a05054a9cc235 archived-at: Mon, 13 Mar 2017 13:33:42 -0000 --94eb2c0bd0f8321a05054a9cc235 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I think the change reduces the chances to run into classloading issues in case there's a bug in Flink (=3D it is using the wrong CL) I've filed a JIRA for the problem: https://issues.apache.org/jira/browse/FLINK-6031 On Fri, Feb 24, 2017 at 9:29 PM, Gyula F=C3=B3ra wro= te: > Hi, > I am wondering whether there is any scenario where the new way makes > anything better under normal circumstances. > > I can only see how it will break things in subtle ways. > > If you think there is any real benefit to the current approach I dont min= d > having it as a default, otherwise I am in favor of reverting to the 1.1 > default. (My logic is that the user will only observe a difference in > behavior when the new setup actually causes problems) > > Gyula > > On Fri, Feb 24, 2017, 17:53 Robert Metzger wrote: > >> The JIRA (https://issues.apache.org/jira/browse/FLINK-4913) doesn't >> mention any particular user or use case. >> >> I honestly care so much if we enable or disable it by default. But since >> its the new default behavior of Flink 1.2. I'm against changing that in >> Flink 1.2.1, that's why I proposed to add a flag to disable it in 1.2.1,= so >> that users upgrading from 1.2.0 to 1.2.1 don't notice it. >> >> On Fri, Feb 24, 2017 at 5:41 PM, Aljoscha Krettek >> wrote: >> >> Did any user have problems with the Flink 1.1 behaviour? If not, we coul= d >> disable it again, by default, and add a flag for adding the user jar to = all >> the classpaths. >> >> On Fri, 24 Feb 2017 at 14:50 Robert Metzger wrote: >> >> I agree with you Gyula, this change is dangerous. I have seen another ca= se >> from a user with Hadoop dependencies that crashed in Flink 1.2.0 that >> didn't in 1.1.x >> >> I wonder if we should introduce a config flag for Flink 1.2.1 to disable >> the behavior if needed. >> >> On Fri, Feb 24, 2017 at 2:27 PM, Ufuk Celebi wrote: >> >> > On Fri, Feb 24, 2017 at 11:05 AM, Gyula F=C3=B3ra >> wrote: >> > > I was not aware of this big change (I know it's my fault) but I am n= ot >> > sure >> > > if I agree with the rationale. >> > >> > No comment on the actual issue from my side, but I strongly disagree >> > that this is your fault. We should have covered this better in the >> > release announcement in my opinion. Of course, this doesn't help now. >> > ;-) >> > >> > =E2=80=93 Ufuk >> > >> >> >> --94eb2c0bd0f8321a05054a9cc235 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I think the change reduces the chances to run into classlo= ading issues in case there's a bug in Flink (=3D it is using the wrong = CL)

I've filed a JIRA for the problem: https://issues.apache.org/jira/browse/F= LINK-6031

On Fri, Feb 24, 2017 at 9:29 PM, Gyula F=C3=B3ra &l= t;gyula.fora@gmai= l.com> wrote:

Hi,
I am wondering whether there is any scenario where the new way makes anythi= ng better under normal circumstances.

I can only see how it will break things in subtle ways.

If you think there is any real benefit to the current approa= ch I dont mind having it as a default, otherwise I am in favor of reverting= to the 1.1 default. (My logic is that the user will only observe a differe= nce in behavior when the new setup actually causes problems)

Gyula


On Fri, Feb 24, 2017, 17:53= Robert Metzger <rmetzger@apache.org> wrote:
The JIRA (https://issues.apache.org/jira= /browse/FLINK-4913) doesn't mention any particular user or use case= .

I hone= stly care so much if we enable or disable it by default. But since its the = new default behavior of Flink 1.2. I'm against changing that in Flink 1= .2.1, that's why I proposed to add a flag to disable it in 1.2.1, so th= at users upgrading from 1.2.0 to 1.2.1 don't notice it.

On Fri, Feb 24, 2017 at 5:41 PM, Aljoscha Krettek <aljosch= a@apache.org> wrote:
Did any user have problem= s with the Flink 1.1 behaviour? If not, we could disable it again, by defau= lt, and add a flag for adding the user jar to all the classpaths.

On Fri, 24 Feb 2017 at 14:50 Rob= ert Metzger <rmetzger@apache.org> wrote:
I agree with you Gyula, this change is = dangerous. I have seen another case
from a user with Hadoop dependencies that crashed in Flink 1.2.0 that
didn't in 1.1.x

I wonder if we should introduce a config flag for Flink 1.2.1 to disable the behavior if needed.

On Fri, Feb 24, 2017 at 2:27 PM, Ufuk Celebi <uce@apache= .org> wrote:

> On Fri, Feb 24, 2017 at 11:05 AM, Gyula F=C3=B3ra <gyula.fora@gmail.com> wrote:
> > I was not aware of this big change (I know it's my fault) but= I am not
> sure
> > if I agree with the rationale.
>
> No comment on the actual issue from my side, but I strongly disagree > that this is your fault. We should have covered this better in the
> release announcement in my opinion. Of course, this doesn't help n= ow.
> ;-)
>
> =E2=80=93 Ufuk
>


--94eb2c0bd0f8321a05054a9cc235--