Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D50FD200C25 for ; Fri, 24 Feb 2017 21:29:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D3B4F160B69; Fri, 24 Feb 2017 20:29:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3957160B62 for ; Fri, 24 Feb 2017 21:29:22 +0100 (CET) Received: (qmail 23190 invoked by uid 500); 24 Feb 2017 20:29:17 -0000 Mailing-List: contact user-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@flink.apache.org Delivered-To: mailing list user@flink.apache.org Received: (qmail 23171 invoked by uid 99); 24 Feb 2017 20:29:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 20:29:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 86025C18DA; Fri, 24 Feb 2017 20:29:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vbXxKqJvobyx; Fri, 24 Feb 2017 20:29:15 +0000 (UTC) Received: from mail-vk0-f45.google.com (mail-vk0-f45.google.com [209.85.213.45]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E164F5F3F5; Fri, 24 Feb 2017 20:29:14 +0000 (UTC) Received: by mail-vk0-f45.google.com with SMTP id k127so18012928vke.0; Fri, 24 Feb 2017 12:29:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s6OGIjAFQS91SYlkwKvvndTfcbvJrIM3bpfkLHJW3uU=; b=Vo5MOiM/9RwFbhfMULW0dMAKywB3P9dfb9w16Vfxr5puUYkc3Cgh86PNftAtlVrfsr DYORWQsslpnxVNCETtnDFwHaJAzlzq/Ly6voz1fhWoYOb9MnWohX6mxBKZrgDY/EJpOH aN3+Z21A4C1K/+LMX0hdZFB72P1DVaNJFZjJothc8Ws5kwQesDd5L5C/KuC/iHPwKXaa T0ELUUBn/4YOWcgOxFiwqCX0KC2xpBOLGt/McmKm61biDkN0nysQiNbkLRv+R2qWQiZH KpKhDlag+AaGtEmJ/ohtSWNjXPu50bsmSfETUJSPdvIYhu0oFoXJoEXyfbrYn17K+kFu Q45g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s6OGIjAFQS91SYlkwKvvndTfcbvJrIM3bpfkLHJW3uU=; b=oafG6tzrID9FFODvBjjNKyJDx/Z95DX9rvQWiPe2Pld46x84ITw7Lqgf9ngvS62kJp 01+L0nI/Ee11VsEE+h5r3PCOExGm5uQLIU/atsZlzksQs2QFuPOccP2Gb8mkv4pSMtqH V4HKKVESBp8sdjxuZjNGiUArlzPKtxEgbKiiHh0Fa9bLjDIgNsAR8MAVIJUfFsJOnpLc b0yAs7pX0r5uBvqHUyihJpZ62lWU436RhwPjyEHyex+bphk0te/I1iZWr1tLltcb4a1Y 9VBIrKGpal6c+5OZGWqa8oBC/k6/Q1UDeyws0F3Umyue263sOq7RUYQmXxN7fKwJ5VEN LfRw== X-Gm-Message-State: AMke39nNhiMYxVNO4Kp8dMz9rDqTuVQyhOUnN9FOMz8FpgG1UAdO/BXKfk1XNZJBpZJs+Bv73woYNxsJuzi/uA== X-Received: by 10.31.49.81 with SMTP id x78mr1990390vkx.82.1487968152800; Fri, 24 Feb 2017 12:29:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Gyula_F=C3=B3ra?= Date: Fri, 24 Feb 2017 20:29:02 +0000 Message-ID: Subject: Re: Frontend classpath issue To: "user@flink.apache.org" Cc: "dev@flink.apache.org" Content-Type: multipart/alternative; boundary=001a114388b02f560d05494c9560 archived-at: Fri, 24 Feb 2017 20:29:24 -0000 --001a114388b02f560d05494c9560 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I am wondering whether there is any scenario where the new way makes anything better under normal circumstances. I can only see how it will break things in subtle ways. If you think there is any real benefit to the current approach I dont mind having it as a default, otherwise I am in favor of reverting to the 1.1 default. (My logic is that the user will only observe a difference in behavior when the new setup actually causes problems) Gyula On Fri, Feb 24, 2017, 17:53 Robert Metzger wrote: > The JIRA (https://issues.apache.org/jira/browse/FLINK-4913) doesn't > mention any particular user or use case. > > I honestly care so much if we enable or disable it by default. But since > its the new default behavior of Flink 1.2. I'm against changing that in > Flink 1.2.1, that's why I proposed to add a flag to disable it in 1.2.1, = so > that users upgrading from 1.2.0 to 1.2.1 don't notice it. > > On Fri, Feb 24, 2017 at 5:41 PM, Aljoscha Krettek > wrote: > > Did any user have problems with the Flink 1.1 behaviour? If not, we could > disable it again, by default, and add a flag for adding the user jar to a= ll > the classpaths. > > On Fri, 24 Feb 2017 at 14:50 Robert Metzger wrote: > > I agree with you Gyula, this change is dangerous. I have seen another cas= e > from a user with Hadoop dependencies that crashed in Flink 1.2.0 that > didn't in 1.1.x > > I wonder if we should introduce a config flag for Flink 1.2.1 to disable > the behavior if needed. > > On Fri, Feb 24, 2017 at 2:27 PM, Ufuk Celebi wrote: > > > On Fri, Feb 24, 2017 at 11:05 AM, Gyula F=C3=B3ra > wrote: > > > I was not aware of this big change (I know it's my fault) but I am no= t > > sure > > > if I agree with the rationale. > > > > No comment on the actual issue from my side, but I strongly disagree > > that this is your fault. We should have covered this better in the > > release announcement in my opinion. Of course, this doesn't help now. > > ;-) > > > > =E2=80=93 Ufuk > > > > > --001a114388b02f560d05494c9560 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi,
I am wondering whether there is any scenario where the new way makes anythi= ng better under normal circumstances.

I can only see how it will break things in subtle ways.

If you think there is any real benefit to the current approa= ch I dont mind having it as a default, otherwise I am in favor of reverting= to the 1.1 default. (My logic is that the user will only observe a differe= nce in behavior when the new setup actually causes problems)

Gyula


On Fri, Feb 24, 2017, 17:53= Robert Metzger <rmetzger@apache.= org> wrote:
The JIRA (https://issues.apach= e.org/jira/browse/FLINK-4913) doesn't mention any particular user o= r use case.

I honestly care so much if we enable or disable it by defau= lt. But since its the new default behavior of Flink 1.2. I'm against ch= anging that in Flink 1.2.1, that's why I proposed to add a flag to disa= ble it in 1.2.1, so that users upgrading from 1.2.0 to 1.2.1 don't noti= ce it.

On Fri, Feb 24, 2017 at 5:41 PM, A= ljoscha Krettek <aljoscha@apache= .org> wrote:
Did any user have prob= lems with the Flink 1.1 behaviour? If not, we could disable it again, by de= fault, and add a flag for adding the user jar to all the classpaths.
<= div class=3D"m_4294648257361204070HOEnZb gmail_msg">

On Fri, 24 Feb 2017 at 14:= 50 Robert Metzger <rmetzger@apache.org> wrote:
I agree with you Gyul= a, this change is dangerous. I have seen another case
from a user with Hadoop dependencies that crashed in Flink 1.2.0 that
didn't in 1.1.x

I wonder if we should introduce a config flag for Flink 1.2.1 to disable the behavior if needed.

On Fri, Feb 24, 2017 at 2:27 PM, Ufuk Celebi <uce@apache.org> wrote:

> On Fri, Feb 24, 2017 at 11:05 AM, Gyula F=C3=B3ra <gyula.fora@gmail.com> wrote:<= br class=3D"m_4294648257361204070m_2582536742832159984gmail_msg gmail_msg"> > > I was not aware of this big change (I know it's my fault) but= I am not
> sure
> > if I agree with the rationale.
>
> No comment on the actual issue from my side, but I strongly disagree > that this is your fault. We should have covered this better in the
> release announcement in my opinion. Of course, this doesn't help n= ow.
> ;-)
>
> =E2=80=93 Ufuk
>

--001a114388b02f560d05494c9560--