flink-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Swapnil Chougule <the.swapni...@gmail.com>
Subject Re: Flink JDBCOutputFormat logs wrong WARN message
Date Thu, 22 Sep 2016 11:32:01 GMT
Thanks Marton !!

On Thu, Sep 22, 2016 at 4:36 PM, Márton Balassi <balassi.marton@gmail.com>
wrote:

> Done. Go ahead, Swapnil.
>
> Best,
> Marton
>
> On Thu, Sep 22, 2016 at 1:03 PM, Swapnil Chougule <the.swapnil09@gmail.com
> > wrote:
>
>> Hi Fabian/ Chesnay
>> Can anybody give me permission to assign JIRA (created for same.)?
>>
>> Thanks,
>> Swapnil
>>
>> On Tue, Sep 20, 2016 at 6:18 PM, Swapnil Chougule <
>> the.swapnil09@gmail.com> wrote:
>>
>>> Thanks Chesnay & Fabian for update.
>>> I will create JIRA issue & open a pull request to fix it.
>>>
>>> Thanks,
>>> Swapnil
>>>
>>> On Tue, Sep 20, 2016 at 2:54 PM, Fabian Hueske <fhueske@gmail.com>
>>> wrote:
>>>
>>>> Yes, the condition needs to be fixed.
>>>>
>>>> @Swapnil, would you like to create a JIRA issue and open a pull request
>>>> to fix it?
>>>>
>>>> Thanks, Fabian
>>>>
>>>> 2016-09-20 11:22 GMT+02:00 Chesnay Schepler <chesnay@apache.org>:
>>>>
>>>>> I would agree that the condition should be changed.
>>>>>
>>>>>
>>>>> On 20.09.2016 10:52, Swapnil Chougule wrote:
>>>>>
>>>>>> I checked following code in Flink JDBCOutputFormat while I was using
>>>>>> in my project work. I found following snippet:
>>>>>>
>>>>>>     @Override
>>>>>>     public void writeRecord(Row row) throws IOException {
>>>>>>
>>>>>>         if (typesArray != null && typesArray.length >
0 &&
>>>>>> typesArray.length == row.productArity()) {
>>>>>>             LOG.warn("Column SQL types array doesn't match arity
of
>>>>>> passed Row! Check the passed array...");
>>>>>>         }
>>>>>>     ...
>>>>>>     }
>>>>>>
>>>>>> I am finding this "if" condition wrong. It should be
>>>>>>
>>>>>> if (typesArray != null && typesArray.length > 0 &&
typesArray.length
>>>>>> != row.productArity())
>>>>>>
>>>>>> As a result, it is logging wrong warning in my logs which is
>>>>>> incorrect. (Even if typearray matches arity of passed row)
>>>>>> May I have inputs on same ?
>>>>>>
>>>>>> Thanks,
>>>>>> Swapnil
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>

Mime
View raw message