Return-Path: X-Original-To: apmail-flink-user-archive@minotaur.apache.org Delivered-To: apmail-flink-user-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0EC7818F15 for ; Tue, 2 Feb 2016 13:32:28 +0000 (UTC) Received: (qmail 74490 invoked by uid 500); 2 Feb 2016 13:32:15 -0000 Delivered-To: apmail-flink-user-archive@flink.apache.org Received: (qmail 74396 invoked by uid 500); 2 Feb 2016 13:32:15 -0000 Mailing-List: contact user-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@flink.apache.org Delivered-To: mailing list user@flink.apache.org Received: (qmail 74386 invoked by uid 99); 2 Feb 2016 13:32:15 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 13:32:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B09A7C1259 for ; Tue, 2 Feb 2016 13:32:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.4 X-Spam-Level: ** X-Spam-Status: No, score=2.4 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FIDLw7tCwRVb for ; Tue, 2 Feb 2016 13:32:05 +0000 (UTC) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 869B031AB2 for ; Tue, 2 Feb 2016 13:32:04 +0000 (UTC) Received: by mail-wm0-f53.google.com with SMTP id p63so22935142wmp.1 for ; Tue, 02 Feb 2016 05:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=Cv/3Y8PaAk7rVw+MLd0VIDpvSKAcNOlgzAKwEmqZ+f8=; b=P9W0fWjE2reTF3ofjfejg0Sec/CqIrRQuhNQzhCLsdY9p+p4wC1S25bNusI5H22Iua wNN5uYwRn1drclM4uErdW/k6PijxrXCWvl9WBqlu5rNSzYev1BBN0h1TRVTpBA+0M8pt u0r1lPuTAqKk4tCHW8R+uwzqPgOEhDwLK9gxfaDDelPMK/Y0fvXWNoAin6dC1csNbe3S sHtjhSGr7U3K3Kp+ONNf6RNrMLS02KPHjBxH8xk/xGbHxAfNxWKJPR6p7itRTgEV9xVg bXRYGksAAkOp7BNMDaupSbKSYTeMLUKdpH81VEGCn1wCURn6FFQCd4CsudjKvkHe7cex zriw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=Cv/3Y8PaAk7rVw+MLd0VIDpvSKAcNOlgzAKwEmqZ+f8=; b=KznyejHtFY6IZ3I0rSDaOAOOFjxUkcrM7olVWLNeCsmEtMjOXSw74C09WJpo2kKp7j ukubgyDIhxR7EwwynRgm/RDRK8l7PR3bj+olcfp6b56nCMyVZWvkP2nyaNsJHh/o/2z7 VQHQn04VBMKYWxW1GVYxUqokEvT9bYsyWNQzh8sjc7Uk20fndFx7L772ccC/2Jb8Fvxj 3urs41ZwkOh90uqEeXDTDzLkWbgGc7vBn12NOknPpbLuSL5uRs/0Ws4HpB0PdC05H/2S 8onOBKyqcANlDm5e1f6Pt9JJoRtRWd/bXCQvSJnFx9iGgubbLmKcK8ZXuYrsEm58JurL 0omg== X-Gm-Message-State: AG10YORm/Rm8oRXcHM5Z/sXoCxz4f72zm/KG2RA4kqF5/39hDFKmj0hzA2hntVHyj1cYb6QvuK04IKju9jh+sQ== X-Received: by 10.194.187.240 with SMTP id fv16mr28570305wjc.39.1454419924219; Tue, 02 Feb 2016 05:32:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.37.198 with HTTP; Tue, 2 Feb 2016 05:31:44 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?M=C3=A1rton_Balassi?= Date: Tue, 2 Feb 2016 14:31:44 +0100 Message-ID: Subject: Re: DataStreamUtils and Scala To: user@flink.apache.org Content-Type: multipart/alternative; boundary=047d7bea4372efff38052ac986e9 --047d7bea4372efff38052ac986e9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Opened the PR. [1] Will merge the re-add "getJavaStream()" method commit as soon as travis passes if no objections, the second approach can be discussed on github. [1] https://github.com/apache/flink/pull/1574 Best, Marton On Mon, Feb 1, 2016 at 10:56 PM, M=C3=A1rton Balassi wrote: > I'll do the fix(es) tomorrow morning. > > Best, > > Marton > > On Mon, Feb 1, 2016, 20:05 Cory Monty wrote= : > >> Thanks for the quick response! >> >> Either solution works for us. >> >> On Mon, Feb 1, 2016 at 12:07 PM, Stephan Ewen wrote: >> >>> I would actually re-add the "getJavaStream()" method. There are probabl= y >>> other cases when people need it, and it does not hurt to expose it. >>> >>> Also, it allows you to combine programs written partly against the Java >>> and Scala API (if you would ever want to do that). >>> >>> Stephan >>> >>> >>> On Mon, Feb 1, 2016 at 6:53 PM, M=C3=A1rton Balassi >> > wrote: >>> >>>> Hey Cory, >>>> >>>> Sorry, I did not mean to break your code. One solution that I could >>>> suggest is to do it the way we have it for the batch api, namely havin= g a >>>> scala version for DataStreamUtils too. It might be placed under >>>> flink-contrib for the time being. >>>> >>>> Would that solution fit your needs? >>>> >>>> On Mon, Feb 1, 2016 at 6:40 PM, Cory Monty >>> > wrote: >>>> >>>>> Hey there, >>>>> >>>>> We were using DataStreamUtils.collect in Scala for automated testing, >>>>> which only works because of `DataStream.getJavaStream` accessor in th= e >>>>> Scala version of `DataStream`. However, a recent commit ( >>>>> https://github.com/apache/flink/commit/086acf681f01f2da530c04289e0682= c56f98a378) >>>>> removed `getJavaStream` and replaced the method with a private versio= n that >>>>> we can no longer access from our tests. >>>>> >>>>> Do you have an alternative version of DataStreamUtils that does not >>>>> require a Java DataStream? >>>>> >>>>> Cheers, >>>>> >>>>> Cory >>>>> >>>> >>>> >>> >> --047d7bea4372efff38052ac986e9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Opened the PR. [1] Will merge the re-add=C2=A0=C2=A0"getJavaStream()" method commit as so= on as travis passes if no objections, the second approach can be discussed = on github.=

On Mon, Feb= 1, 2016 at 10:56 PM, M=C3=A1rton Balassi <balassi.marton@gmail.com= > wrote:

I&#= 39;ll do the fix(es) tomorrow morning.

Best,

Marton


On Mon, Feb 1, 2016, 20:05= =C2=A0Cory Monty <cory.monty@getbraintree.com> wrote:
Thanks for the quick response!

Either solution works for us.=C2=A0

On Mon, Feb 1, 2016 at= 12:07 PM, Stephan Ewen <sewen@apache.org> wrote:
I would actually re-add the "g= etJavaStream()" method. There are probably other cases when people nee= d it, and it does not hurt to expose it.

Also, it allows= you to combine programs written partly against the Java and Scala API (if = you would ever want to do that).
Stephan


On Mon, Feb 1, 2016 a= t 6:53 PM, M=C3=A1rton Balassi <balassi.marton@gmail.com> wrote:
Hey Cory,
Sorry, I did not mean to break your code. One solution tha= t I could suggest is to do it the way we have it for the batch api, namely = having a scala version for DataStreamUtils too. It might be placed under fl= ink-contrib for the time being.

Would that solutio= n fit your needs?

On Mon, Feb 1, 2016 at 6:40 PM, Cory Monty <cory.monty@getbraintree.com> wrote:
Hey there,

We were using = DataStreamUtils.collect in Scala for automated testing, which only works be= cause of `DataStream.getJavaStream` accessor in the Scala version of `DataS= tream`. However, a recent commit (https:= //github.com/apache/flink/commit/086acf681f01f2da530c04289e0682c56f98a378) removed `getJavaStream` and replaced the method with a private version = that we can no longer access from our tests.







--047d7bea4372efff38052ac986e9--