flink-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Rohrmann <trohrm...@apache.org>
Subject Re: Flink packaging makes life hard for SBT fat jar's
Date Mon, 22 Feb 2016 18:01:53 GMT
Hi Shikhar,

you're right that including a connector dependency would have let us spot
the problem earlier. In fact, any project building a fat jar with SBT would
have failed without setting the flink dependencies to provided.

The problem is that the template is a general purpose template. Thus, it is
also used for batch jobs. I fear that by including a connector in the
default `build.sbt` file, many users will forget about it and simply
include it in their job jars. I admit that I'm not totally consistent with
my argumentation here because we're also including the `flink-scala` and
`flink-streaming-scala` dependency per default. But I would like to keep
the initial list of dependencies as lean as possible.

What I've done, however, is to add testing SBT builds with a connector to
our release testing tasks. This should catch similar problems which you've
came across.

Cheers,
Till

On Mon, Feb 22, 2016 at 6:20 PM, shikhar <shikhar@schmizz.net> wrote:

> Hi Till,
>
> Thanks so much for sorting this out!
>
> One suggestion, can the Flink template depend on a connector (Kafka?) --
> this would verify that assembly works smoothly for a very common use-case
> when you need to include connector JAR's.
>
> Cheers,
>
> Shikhar
>
>
>
> --
> View this message in context:
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-packaging-makes-life-hard-for-SBT-fat-jar-s-tp4897p5078.html
> Sent from the Apache Flink User Mailing List archive. mailing list archive
> at Nabble.com.
>

Mime
View raw message