From issues-return-531938-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Sep 1 06:21:04 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 3DBE718068A for ; Wed, 1 Sep 2021 08:21:04 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 7A8294167A for ; Wed, 1 Sep 2021 06:21:03 +0000 (UTC) Received: (qmail 47664 invoked by uid 500); 1 Sep 2021 06:21:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 47627 invoked by uid 99); 1 Sep 2021 06:21:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Sep 2021 06:21:01 +0000 From: =?utf-8?q?GitBox?= To: issues@flink.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bflink=5D_HuangXingBo_commented_on_a_change_in_pull?= =?utf-8?q?_request_=2317090=3A_=5BFLINK-24082=5D=5Bpython=5D_Fix_Python_UDT?= =?utf-8?q?F_to_handle_properly_when_the_result_is_a_generator_of_Row?= Message-ID: <163047726174.16310.5381854177907731658.asfpy@gitbox.apache.org> Date: Wed, 01 Sep 2021 06:21:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: HuangXingBo commented on a change in pull request #17090: URL: https://github.com/apache/flink/pull/17090#discussion_r699873020 ########## File path: flink-python/pyflink/fn_execution/coder_impl_fast.pyx ########## @@ -19,6 +19,8 @@ # cython: infer_types = True # cython: profile=True # cython: boundscheck=False, wraparound=False, initializedcheck=False, cdivision=True +from types import GeneratorType +from typing import Iterable Review comment: change to `from collections import Iterable, Generator`? ########## File path: flink-python/pyflink/fn_execution/coder_impl_fast.pyx ########## @@ -19,6 +19,8 @@ # cython: infer_types = True # cython: profile=True # cython: boundscheck=False, wraparound=False, initializedcheck=False, cdivision=True +from types import GeneratorType Review comment: put these two imports together with other python imports ########## File path: flink-python/pyflink/fn_execution/beam/beam_coder_impl_slow.py ########## @@ -18,9 +18,11 @@ import datetime import decimal +from types import GeneratorType Review comment: change to `from collections import Iterable, Generator` and put this import after the `import struct` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org