From issues-return-531257-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Aug 31 10:13:02 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 3D0BE180645 for ; Tue, 31 Aug 2021 12:13:02 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 722E5402DD for ; Tue, 31 Aug 2021 10:13:01 +0000 (UTC) Received: (qmail 30189 invoked by uid 500); 31 Aug 2021 10:13:01 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 30180 invoked by uid 99); 31 Aug 2021 10:13:01 -0000 Received: from mailrelay1-he-de.apache.org (HELO mailrelay1-he-de.apache.org) (116.203.21.61) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Aug 2021 10:13:01 +0000 Received: from jira2-he-de.apache.org (jira2-he-de.apache.org [168.119.33.54]) by mailrelay1-he-de.apache.org (ASF Mail Server at mailrelay1-he-de.apache.org) with ESMTPS id 31CA13E96A for ; Tue, 31 Aug 2021 10:13:00 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 1682DC8075D for ; Tue, 31 Aug 2021 10:13:00 +0000 (UTC) Date: Tue, 31 Aug 2021 10:13:00 +0000 (UTC) From: "Timo Walther (Jira)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407214#comment-17407214 ] Timo Walther commented on FLINK-24054: -------------------------------------- It really depends on the use case. For our current Kafka sink implementation, this might not be an issue. But strictly speaking the current behavior is incorrect. +I and +U might trigger different downstream logic. [See this example|https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/DataStreamJavaITCase.java#L643] I had to modify the materialization logic because +U requires a look up by primary key, whereas +I should simply be forwarded. > Let SinkUpsertMaterializer emit +U instead of only +I > ----------------------------------------------------- > > Key: FLINK-24054 > URL: https://issues.apache.org/jira/browse/FLINK-24054 > Project: Flink > Issue Type: Bug > Components: Table SQL / Runtime > Reporter: Timo Walther > Assignee: Timo Walther > Priority: Blocker > Fix For: 1.14.0 > > > Currently, {{SinkUpsertMaterializer}} is not able to emit +U's but will always emit +I's. Thus, resulting changelogs are incorrect strictly speaking and only valid when treating +U and +I as similar changes in downstream operators. -- This message was sent by Atlassian Jira (v8.3.4#803005)