From issues-return-521599-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Aug 10 15:18:36 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A0572180634 for ; Tue, 10 Aug 2021 17:18:36 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 37AE461730 for ; Tue, 10 Aug 2021 15:18:32 +0000 (UTC) Received: (qmail 66870 invoked by uid 500); 10 Aug 2021 15:18:27 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 66844 invoked by uid 99); 10 Aug 2021 15:18:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Aug 2021 15:18:27 +0000 From: =?utf-8?q?GitBox?= To: issues@flink.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bflink=5D_gaoyunhaii_commented_on_a_change_in_pull_?= =?utf-8?q?request_=2316655=3A_=5BFLINK-23512=5D=5Bruntime=5D=5Bcheckpoint?= =?utf-8?q?=5D_Check_for_illegal_modifications_of_JobGraph_with_partially_fi?= =?utf-8?q?nished_operators?= Message-ID: <162860870741.16310.8024047790078782614.asfpy@gitbox.apache.org> Date: Tue, 10 Aug 2021 15:18:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: gaoyunhaii commented on a change in pull request #16655: URL: https://github.com/apache/flink/pull/16655#discussion_r686116617 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java ########## @@ -59,6 +60,8 @@ private static final Logger LOG = LoggerFactory.getLogger(OperatorSubtaskState.class); + public static final OperatorSubtaskState FINISHED = new OperatorSubtaskState(true); + private static final long serialVersionUID = -2394696997971923995L; Review comment: Yes, since users may upgrade from the older version, we might need to keep the compatibility. But to avoid unexpected problems I change the implementation to not modify this class, but introduce a new `FinishedOperatorSubtaskState` subclass specially. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org