flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] gaoyunhaii commented on a change in pull request #16655: [FLINK-23512][runtime][checkpoint] Check for illegal modifications of JobGraph with partially finished operators
Date Tue, 10 Aug 2021 15:18:27 GMT

gaoyunhaii commented on a change in pull request #16655:
URL: https://github.com/apache/flink/pull/16655#discussion_r686116617



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java
##########
@@ -59,6 +60,8 @@
 
     private static final Logger LOG = LoggerFactory.getLogger(OperatorSubtaskState.class);
 
+    public static final OperatorSubtaskState FINISHED = new OperatorSubtaskState(true);
+
     private static final long serialVersionUID = -2394696997971923995L;

Review comment:
       Yes, since users may upgrade from the older version, we might need to keep the compatibility.

   
   But to avoid unexpected problems I change the implementation to not modify this class,
but introduce a new `FinishedOperatorSubtaskState` subclass specially.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message