flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wsry commented on a change in pull request #16465: [FLINK-22910][runtime] Refine ShuffleMaster lifecycle management for pluggable shuffle service framework
Date Sun, 01 Aug 2021 04:56:43 GMT

wsry commented on a change in pull request #16465:
URL: https://github.com/apache/flink/pull/16465#discussion_r680450456



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -976,6 +991,7 @@ private void jobStatusChanged(final JobStatus newJobStatus) {
                         }
                     });
 
+            shuffleMaster.unregisterJob(jobGraph.getJobID());

Review comment:
       Previously, I was thinking that we should release all partitions when a job is unregistered
and we should only do that when the job reach the globally terminated state. But after rethinking
about that, I think we already released all partitions in the jobStatusChanged method for
normal termination and for error termination, we can decide whether to release all partitions
in ShuffleMaster. So I think the suggestion makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message