flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dawidwys commented on a change in pull request #16221: [FLINK-22881] Tasks are blocked while broadcasting stream status
Date Tue, 22 Jun 2021 09:11:21 GMT

dawidwys commented on a change in pull request #16221:
URL: https://github.com/apache/flink/pull/16221#discussion_r656030004



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -652,11 +652,11 @@ private void processStreamStatus(StreamStatus streamStatus, int index)
throws Ex
         }
     }
 
-    public final void processStreamStatus1(StreamStatus streamStatus) throws Exception {
+    public void processStreamStatus1(StreamStatus streamStatus) throws Exception {
         processStreamStatus(streamStatus, 0);
     }
 
-    public final void processStreamStatus2(StreamStatus streamStatus) throws Exception {
+    public void processStreamStatus2(StreamStatus streamStatus) throws Exception {

Review comment:
       I override these two methods in `WatermarkAssignerOperator` which extends from `AbstractStreamOperator`.
Therefore I need to remove the `final` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message