flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jark Wu (Jira)" <j...@apache.org>
Subject [jira] [Closed] (FLINK-22080) Refactor SqlClient for better testing
Date Thu, 20 May 2021 13:27:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-22080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jark Wu closed FLINK-22080.
---------------------------
    Resolution: Fixed

This has been addressed by FLINK-22104.

> Refactor SqlClient for better testing
> -------------------------------------
>
>                 Key: FLINK-22080
>                 URL: https://issues.apache.org/jira/browse/FLINK-22080
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Client
>            Reporter: Jark Wu
>            Priority: Major
>              Labels: stale-major
>
> Currently, we added a JUnit Rule {{TerminalStreamsResource}} to replace {{System.in}}
and {{System.out}} stream to get the output of SqlClient. However, this is not safe, especially
used by multiple tests. 
> We should refactor {{SqlClient}} to expose a new testing purpose {{main}} method which
can pass in custom {{InputStream}} and {{OutputStream}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message