flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Date Thu, 07 Jan 2021 10:18:01 GMT

zentol commented on a change in pull request #14577:
URL: https://github.com/apache/flink/pull/14577#discussion_r553235608



##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1781,6 +1781,12 @@ private void setClusterEntrypointInfoToConfig(final ApplicationReport
report) {
 
         flinkConfiguration.set(
                 YarnConfigOptions.APPLICATION_ID, ConverterUtils.toString(clusterId));
+
+        // set cluster-id to app id if not specified
+        if (!flinkConfiguration.contains(HighAvailabilityOptions.HA_CLUSTER_ID)) {

Review comment:
       Should we deduplicate/sync this block with the one in `#startAppMaster`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message