flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] SteNicholas opened a new pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
Date Wed, 11 Nov 2020 05:58:59 GMT

SteNicholas opened a new pull request #14028:
URL: https://github.com/apache/flink/pull/14028


   ## What is the purpose of the change
   
   *Currently, different implementations of the `JobClient` throw different exceptions. The
`ClusterClientJobClientAdapter` wraps the exception from the `JobResult.toJobExecutionResult()`
into a `ProgramInvocationException`, the `MiniClusterJobClient` simply wraps it in a `CompletionException`
and the `EmbeddedJobClient` wraps it into an `UnsuccessfulExecutionException`. `JobResult.toJobExecutionResult()`
should make the exception uniform and part of the contract through `JobExecutionResultException`
which exception includes the status of the application.*
   
   ## Brief change log
   
     - *Add `JobExecutionResultException` to make the exception uniform and part of the contract
for `JobResult.toJobExecutionResult()`.*
     - *`ClusterClientJobClientAdapter`, `MiniClusterJobClient` and `EmbeddedJobClient` uniform
the exception to `JobExecutionResultException`.*
   
   ## Verifying this change
   
     - *Modify `ApplicationDispatcherBootstrapTest` and `PerJobMiniClusterFactoryTest.java`
to update the `UnsuccessfulExecutionException` check to the `JobExecutionResultException`.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message