flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] aalexandrov commented on a change in pull request #13770: [FLINK-18858][connector-kinesis] Add Kinesis sources and sinks
Date Sat, 07 Nov 2020 11:23:53 GMT

aalexandrov commented on a change in pull request #13770:
URL: https://github.com/apache/flink/pull/13770#discussion_r519167157



##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/table/KinesisOptions.java
##########
@@ -44,26 +49,54 @@
 		private KinesisOptions() {
 		}
 
-		// --------------------------------------------------------------------------------------------
+		// -----------------------------------------------------------------------------------------
 		// Kinesis specific options
-		// --------------------------------------------------------------------------------------------
+		// -----------------------------------------------------------------------------------------
 
 		/**
-		 * Prefix for properties delegated to the
+		 * Prefix for properties defined in
+		 * {@link org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants}
+		 * that are delegated to
 		 * {@link org.apache.flink.streaming.connectors.kinesis.FlinkKinesisConsumer} and
 		 * {@link org.apache.flink.streaming.connectors.kinesis.FlinkKinesisProducer}.
 		 */
-		public static final String PROPERTIES_PREFIX = "properties.";
+		public static final String AWS_PROPERTIES_PREFIX = "aws.";
+
+		/**
+		 * Prefix for properties defined in
+		 * {@link org.apache.flink.streaming.connectors.kinesis.config.ConsumerConfigConstants}
+		 * that are delegated to
+		 * {@link org.apache.flink.streaming.connectors.kinesis.FlinkKinesisConsumer}.
+		 */
+		public static final String CONSUMER_PREFIX = "source.";

Review comment:
       No problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message