From issues-return-396887-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Sep 9 08:16:11 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A767A180652 for ; Wed, 9 Sep 2020 10:16:11 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id CF437121CB2 for ; Wed, 9 Sep 2020 08:16:10 +0000 (UTC) Received: (qmail 26300 invoked by uid 500); 9 Sep 2020 08:16:10 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 26291 invoked by uid 99); 9 Sep 2020 08:16:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2020 08:16:10 +0000 From: =?utf-8?q?GitBox?= To: issues@flink.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bflink=5D_wuchong_commented_on_a_change_in_pull_req?= =?utf-8?q?uest_=2311830=3A_=5BFLINK-17096=5D_=5Btable=5D_Support_state_ttl_?= =?utf-8?q?for_Mini-Batch_Group_Agg_using_StateTtlConfig?= Message-ID: <159963937044.32230.1436713071303648802.asfpy@gitbox.apache.org> Date: Wed, 09 Sep 2020 08:16:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: wuchong commented on a change in pull request #11830: URL: https://github.com/apache/flink/pull/11830#discussion_r485423944 ########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/aggregate/GroupAggFunction.java ########## @@ -83,61 +85,57 @@ // stores the accumulators private transient ValueState accState = null; + private final StateTtlConfig ttlConfig; Review comment: I think we can simply use `stateRetentionTime > 0` to check whether ttl is enabled. We can also wrap that as a utility if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org