flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Metzger (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-19164) Release scripts break other dependency versions unintentionally
Date Wed, 09 Sep 2020 07:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192687#comment-17192687
] 

Robert Metzger commented on FLINK-19164:
----------------------------------------

I see, you are raising a valid point, and I like your proposal for addressing this. Would
you be up for opening a pull request to change the scripts?

I would use the second variant (without adding the plugin to the project).

> Release scripts break other dependency versions unintentionally
> ---------------------------------------------------------------
>
>                 Key: FLINK-19164
>                 URL: https://issues.apache.org/jira/browse/FLINK-19164
>             Project: Flink
>          Issue Type: Bug
>          Components: Deployment / Scripts, Release System
>            Reporter: Serhat Soydan
>            Priority: Minor
>
> All the scripts below has a line to change the old version to new version in pom files.
> [https://github.com/apache/flink/blob/master/tools/change-version.sh#L31]
> [https://github.com/apache/flink/blob/master/tools/releasing/create_release_branch.sh#L60]
> [https://github.com/apache/flink/blob/master/tools/releasing/update_branch_version.sh#L52]
>  
> It works like find & replace so it is prone to unintentional errors. Any dependency
with a version equals to "old version" might be automatically changed to "new version". See
below to see how to produce a similar case. 
>  
> +How to re-produce the bug:+
>  * Clone/Fork Flink repo and for example checkout version v*1.11.1* 
>  * Apply any changes you need
>  * Run "create_release_branch.sh" script with OLD_VERSION=*1.11.1* NEW_VERSION={color:#de350b}*1.12.0*{color}
>  ** In parent pom.xml, an auto find&replace of maven-dependency-analyzer version
will be done automatically and *unintentionally* which will break the build.
>  
>                         <dependency>
>                             <groupId>org.apache.maven.shared</groupId>
>                             <artifactId>maven-dependency-analyzer</artifactId>
>                             <version>*1.11.1*</version>
>                         </dependency>
>  
>                         <dependency>
>                             <groupId>org.apache.maven.shared</groupId>
>                             <artifactId>maven-dependency-analyzer</artifactId>
>                             <version>{color:#de350b}*1.12.0*{color}</version>
>                         </dependency>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message