flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wsry commented on a change in pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented
Date Wed, 23 Sep 2020 04:54:20 GMT

wsry commented on a change in pull request #13447:
URL: https://github.com/apache/flink/pull/13447#discussion_r493159836



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingResultPartition.java
##########
@@ -63,6 +63,22 @@ public BoundedBlockingResultPartition(
 			bufferPoolFactory);
 	}
 
+	@Override
+	public void flush(int targetSubpartition) {
+		finishBroadcastBufferBuilder();

Review comment:
       This logic is already in BoundedBlockingResultPartition and should has no impact on
streaming/pipelined cases. I guess the source file name is misread?

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingResultPartition.java
##########
@@ -63,6 +63,22 @@ public BoundedBlockingResultPartition(
 			bufferPoolFactory);
 	}
 
+	@Override
+	public void flush(int targetSubpartition) {
+		finishBroadcastBufferBuilder();

Review comment:
       This logic is already in BoundedBlockingResultPartition and should have no impact on
streaming/pipelined cases. I guess the source file name is misread?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message