flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lsyldliu commented on a change in pull request #11830: [FLINK-17096] [table] Support state ttl for Mini-Batch Group Agg using StateTtlConfig
Date Wed, 09 Sep 2020 07:05:22 GMT

lsyldliu commented on a change in pull request #11830:
URL: https://github.com/apache/flink/pull/11830#discussion_r485384295



##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/aggregate/GroupAggFunction.java
##########
@@ -83,61 +85,57 @@
 	// stores the accumulators
 	private transient ValueState<RowData> accState = null;
 
+	private final StateTtlConfig ttlConfig;

Review comment:
       @wuchong sorry, I looked the code again, `ttlConfig` object also used in `processElement`
method, so it must be global object. However, it only used in `open` method in other classes,
to keep consistent, I think we can set ttlConfig as global object in other classes, what do
you thinkļ¼Ÿ




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message