From issues-return-385264-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Jul 23 08:59:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 02954180642 for ; Thu, 23 Jul 2020 10:59:39 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 63A961254A2 for ; Thu, 23 Jul 2020 08:59:05 +0000 (UTC) Received: (qmail 5854 invoked by uid 500); 23 Jul 2020 08:59:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 5845 invoked by uid 99); 23 Jul 2020 08:59:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2020 08:59:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3753842FDA for ; Thu, 23 Jul 2020 08:59:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id EF682782350 for ; Thu, 23 Jul 2020 08:59:00 +0000 (UTC) Date: Thu, 23 Jul 2020 08:59:00 +0000 (UTC) From: "Jiangjie Qin (Jira)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-18641) "Failure to finalize checkpoint" error in MasterTriggerRestoreHook MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-18641?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D171= 63359#comment-17163359 ]=20 Jiangjie Qin commented on FLINK-18641: -------------------------------------- [~SleePy]=C2=A0Right, the master hooks with ExternalInducedSource are not r= eally that robust in my opinion. I think the fix is just a few lines of code. However, apparently we do not = have a test covering the use case of {{ExternallyInducedSource}}. So as usu= al, I think the major work here will be writing the tests. > "Failure to finalize checkpoint" error in MasterTriggerRestoreHook > ------------------------------------------------------------------ > > Key: FLINK-18641 > URL: https://issues.apache.org/jira/browse/FLINK-18641 > Project: Flink > Issue Type: Bug > Components: Runtime / Checkpointing > Affects Versions: 1.11.0 > Reporter: Brian Zhou > Priority: Major > > https://github.com/pravega/flink-connectors is a Pravega connector for Fl= ink. The ReaderCheckpointHook[1] class uses the Flink `MasterTriggerRestore= Hook` interface to trigger the Pravega checkpoint during Flink checkpoints = to make sure the data recovery. The checkpoint recovery tests are running f= ine in Flink 1.10, but it has below issues in Flink 1.11 causing the tests = time out. Suspect it is related to the checkpoint coordinator thread model = changes in Flink 1.11 > Error stacktrace: > {code} > 2020-07-09 15:39:39,999 30945 [jobmanager-future-thread-5] WARN o.a.f.ru= ntime.jobmaster.JobMaster - Error while processing checkpoint acknowledgeme= nt message > org.apache.flink.runtime.checkpoint.CheckpointException: Could not finali= ze the pending checkpoint 3. Failure reason: Failure to finalize checkpoint= . > at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.com= pletePendingCheckpoint(CheckpointCoordinator.java:1033) > at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.rec= eiveAcknowledgeMessage(CheckpointCoordinator.java:948) > at org.apache.flink.runtime.scheduler.SchedulerBase.lambda$ackno= wledgeCheckpoint$4(SchedulerBase.java:802) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors= .java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFut= ureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFut= ureTask.run(ScheduledThreadPoolExecutor.java:293) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolE= xecutor.java:1149) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPool= Executor.java:624) > at java.lang.Thread.run(Thread.java:748) > Caused by: org.apache.flink.util.SerializedThrowable: Pending checkpoint = has not been fully acknowledged yet > at org.apache.flink.util.Preconditions.checkState(Preconditions.= java:195) > at org.apache.flink.runtime.checkpoint.PendingCheckpoint.finaliz= eCheckpoint(PendingCheckpoint.java:298) > at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.com= pletePendingCheckpoint(CheckpointCoordinator.java:1021) > ... 9 common frames omitted > {code} > More detail in this mailing thread: http://apache-flink-user-mailing-list= -archive.2336050.n4.nabble.com/Pravega-connector-cannot-recover-from-the-ch= eckpoint-due-to-quot-Failure-to-finalize-checkpoint-quot-td36652.html > Also in https://github.com/pravega/flink-connectors/issues/387 -- This message was sent by Atlassian Jira (v8.3.4#803005)