flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] twalthr commented on pull request #12959: [FLINK-15803][table] Unify validation for all kinds of UDFs
Date Wed, 22 Jul 2020 13:56:50 GMT

twalthr commented on pull request #12959:
URL: https://github.com/apache/flink/pull/12959#issuecomment-662468220


   Thanks for the review @aljoscha. Your change summary is correct. The changes around `GenericRowData`
are necessary because `GenericRowData` is not an official conversion class for the ROW type.
It must be `RowData`. It is dangerous to make implicit assumptions how the `RowData` is implemented.
I didn't want to change the existing functions too much. So I decided to fix the tests the
way it is in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message