flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] twalthr commented on a change in pull request #12959: [FLINK-15803][table] Unify validation for all kinds of UDFs
Date Wed, 22 Jul 2020 13:47:45 GMT

twalthr commented on a change in pull request #12959:
URL: https://github.com/apache/flink/pull/12959#discussion_r458804564



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java
##########
@@ -215,6 +216,38 @@ public static void validateClass(Class<? extends UserDefinedFunction>
functionCl
 		validateClass(functionClass, true);
 	}
 
+	/**
+	 * Validates a {@link UserDefinedFunction} class for usage in the runtime.
+	 *
+	 * <p>Note: This is for the final validation when actual {@link DataType}s for arguments
and result

Review comment:
       thanks for the hint, actually I'm aware of this trick. but I find this one more readable
in the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message