flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] tillrohrmann commented on a change in pull request #12815: [FLINK-17075][coordination] Reconcile deployed Executions
Date Fri, 03 Jul 2020 15:56:01 GMT

tillrohrmann commented on a change in pull request #12815:
URL: https://github.com/apache/flink/pull/12815#discussion_r449642784



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterExecutionDeploymentReconciliationTest.java
##########
@@ -86,38 +88,29 @@ public void setup() {
 		haServices.setCheckpointRecoveryFactory(new StandaloneCheckpointRecoveryFactory());
 	}
 
-	@After
-	public void shutdown() {
-		rpcService.clearGateways();
-	}
-
-	@BeforeClass
-	public static void setupClass() {
-		rpcService = new TestingRpcService();
-	}
-
 	@AfterClass
 	public static void shutdownClass() throws ExecutionException, InterruptedException {
-		rpcService.stopService().get();
+		RPC_SERVICE_RESOURCE.getTestingRpcService().stopService().get();

Review comment:
       I think the resource will take care of shutting the service down.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message