flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicholas Jiang (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-17726) Scheduler should take care of tasks directly canceled by TaskManager
Date Mon, 01 Jun 2020 09:24:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-17726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120883#comment-17120883

Nicholas Jiang commented on FLINK-17726:

[~zhuzh]I have double checked the methods that trigger cancel task operation, including cancelOrFailAndCancelInvokable,
cancelExecution which are based on TaskCanceler, cancelInvokable which is based on invokable's
cancel method and caller of method transitionState. After checking again, the case that a
directly CANCELED task happens when its upstream task was canceled/failed doesn't exist. 
IMO, my solution would be to modify tasks that transitions to CANCELED from all states except
from CANCELING to FAILED status as same as the solution you mentioned. What do you think about

> Scheduler should take care of tasks directly canceled by TaskManager
> --------------------------------------------------------------------
>                 Key: FLINK-17726
>                 URL: https://issues.apache.org/jira/browse/FLINK-17726
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.11.0, 1.12.0
>            Reporter: Zhu Zhu
>            Assignee: Nicholas Jiang
>            Priority: Critical
>             Fix For: 1.11.0, 1.12.0
> JobManager will not trigger failure handling when receiving CANCELED task update. 
> This is because CANCELED tasks are usually caused by another FAILED task. These CANCELED
tasks will be restarted by the failover process triggered  FAILED task.
> However, if a task is directly CANCELED by TaskManager due to its own runtime issue,
the task will not be recovered by JM and thus the job would hang.
> This is a potential issue and we should avoid it.
> A possible solution is to let JobManager treat tasks transitioning to CANCELED from all
states except from CANCELING as failed tasks. 

This message was sent by Atlassian Jira

View raw message