flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] AHeise commented on a change in pull request #12575: [FLINK-18094][checkpointing] Unifies the creation of BarrierHandlers and CheckpointedInputGate.
Date Thu, 11 Jun 2020 19:39:01 GMT

AHeise commented on a change in pull request #12575:
URL: https://github.com/apache/flink/pull/12575#discussion_r439024712



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputGateUtil.java
##########
@@ -38,18 +40,18 @@ public static InputGate createInputGate(Collection<IndexedInputGate>
inputGates1
 		List<IndexedInputGate> gates = new ArrayList<>(inputGates1.size() + inputGates2.size());
 		gates.addAll(inputGates1);
 		gates.addAll(inputGates2);
-		return createInputGate(gates.toArray(new IndexedInputGate[gates.size()]));
+		return createInputGate(gates);
 	}
 
-	public static InputGate createInputGate(IndexedInputGate[] inputGates) {
-		if (inputGates.length <= 0) {
+	public static InputGate createInputGate(Collection<IndexedInputGate> inputGates) {

Review comment:
       I had to change a bit of the invoking code, but it's not much because ultimately Lists
are used everywhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message