From issues-return-331773-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Mar 4 11:58:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DDA5C180668 for ; Wed, 4 Mar 2020 12:58:27 +0100 (CET) Received: (qmail 53611 invoked by uid 500); 4 Mar 2020 11:58:27 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 53536 invoked by uid 99); 4 Mar 2020 11:58:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2020 11:58:26 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] [flink] azagrebin commented on a change in pull request #11285: [FLINK-16189][e2e] Remove test logic from FlinkDistribution Message-ID: <158332310688.343.15655152436693305422.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 04 Mar 2020 11:58:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit azagrebin commented on a change in pull request #11285: [FLINK-16189][e2e] Remove test logic from FlinkDistribution URL: https://github.com/apache/flink/pull/11285#discussion_r387581958 ########## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResource.java ########## @@ -51,16 +58,28 @@ private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneFlinkResource.class); - private final FlinkDistribution distribution = new FlinkDistribution(); + private final TemporaryFolder temporaryFolder = new TemporaryFolder(); + private final Path distributionDirectory; + @Nullable + private final Path logBackupDirectory; private final FlinkResourceSetup setup; - LocalStandaloneFlinkResource(FlinkResourceSetup setup) { + private FlinkDistribution distribution; + + LocalStandaloneFlinkResource(Path distributionDirectory, Optional logBackupDirectory, FlinkResourceSetup setup) { Review comment: ```suggestion LocalStandaloneFlinkResource(Path distributionDirectory, @Nullable Path logBackupDirectory, FlinkResourceSetup setup) { ``` code style ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services