flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] azagrebin commented on a change in pull request #11285: [FLINK-16189][e2e] Remove test logic from FlinkDistribution
Date Wed, 04 Mar 2020 11:58:26 GMT
azagrebin commented on a change in pull request #11285:  [FLINK-16189][e2e] Remove test logic
from FlinkDistribution
URL: https://github.com/apache/flink/pull/11285#discussion_r387620565
 
 

 ##########
 File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResourceFactory.java
 ##########
 @@ -29,9 +33,21 @@
 public final class LocalStandaloneFlinkResourceFactory implements FlinkResourceFactory {
 	private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneFlinkResourceFactory.class);
 
+	private static final ParameterProperty<Path> DISTRIBUTION_DIRECTORY = new ParameterProperty<>("distDir",
Paths::get);
+	private static final ParameterProperty<Path> DISTRIBUTION_LOG_BACKUP_DIRECTORY = new
ParameterProperty<>("logBackupDir", Paths::get);
+
 	@Override
 	public Optional<FlinkResource> create(FlinkResourceSetup setup) {
+		Optional<Path> distributionDirectory = DISTRIBUTION_DIRECTORY.get();
+		if (!distributionDirectory.isPresent()) {
+			LOG.warn("The distDir property was not set. You can set it when running maven via -DdistDir=<path>
.");
 
 Review comment:
   Does it mean that running e2e tests from IDE will always need to set `distDir` manually?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message