flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] azagrebin commented on a change in pull request #11285: [FLINK-16189][e2e] Remove test logic from FlinkDistribution
Date Wed, 04 Mar 2020 11:58:26 GMT
azagrebin commented on a change in pull request #11285:  [FLINK-16189][e2e] Remove test logic
from FlinkDistribution
URL: https://github.com/apache/flink/pull/11285#discussion_r387581958
 
 

 ##########
 File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResource.java
 ##########
 @@ -51,16 +58,28 @@
 
 	private static final Logger LOG = LoggerFactory.getLogger(LocalStandaloneFlinkResource.class);
 
-	private final FlinkDistribution distribution = new FlinkDistribution();
+	private final TemporaryFolder temporaryFolder = new TemporaryFolder();
+	private final Path distributionDirectory;
+	@Nullable
+	private final Path logBackupDirectory;
 	private final FlinkResourceSetup setup;
 
-	LocalStandaloneFlinkResource(FlinkResourceSetup setup) {
+	private FlinkDistribution distribution;
+
+	LocalStandaloneFlinkResource(Path distributionDirectory, Optional<Path> logBackupDirectory,
FlinkResourceSetup setup) {
 
 Review comment:
   ```suggestion
   	LocalStandaloneFlinkResource(Path distributionDirectory, @Nullable Path logBackupDirectory,
FlinkResourceSetup setup) {
   ```
   code style

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message