From issues-return-299467-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Dec 3 22:39:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 74052180629 for ; Tue, 3 Dec 2019 23:39:29 +0100 (CET) Received: (qmail 95501 invoked by uid 500); 3 Dec 2019 22:39:26 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 95303 invoked by uid 99); 3 Dec 2019 22:39:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2019 22:39:25 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] [flink] bowenli86 commented on a change in pull request #10388: [FLINK-14912][Table] create, drop catalog functions through catalog manager Message-ID: <157541276541.21862.18087405116678675746.gitbox@gitbox.apache.org> Date: Tue, 03 Dec 2019 22:39:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bowenli86 commented on a change in pull request #10388: [FLINK-14912][Table] create, drop catalog functions through catalog manager URL: https://github.com/apache/flink/pull/10388#discussion_r353460547 ########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala ########## @@ -117,7 +117,9 @@ class FlinkPlannerImpl( } // no need to validate row type for DDL and insert nodes. if (sqlNode.getKind.belongsTo(SqlKind.DDL) - || sqlNode.getKind == SqlKind.INSERT) { + || sqlNode.getKind == SqlKind.INSERT + || sqlNode.getKind == SqlKind.CREATE_FUNCTION + || sqlNode.getKind == SqlKind.DROP_FUNCTION) { Review comment: miss ALTER_FUNCTION? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services