flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #10388: [FLINK-14912][Table] create, drop catalog functions through catalog manager
Date Tue, 03 Dec 2019 22:39:25 GMT
bowenli86 commented on a change in pull request #10388: [FLINK-14912][Table] create, drop catalog
functions through catalog manager
URL: https://github.com/apache/flink/pull/10388#discussion_r353460547
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala
 ##########
 @@ -117,7 +117,9 @@ class FlinkPlannerImpl(
       }
       // no need to validate row type for DDL and insert nodes.
       if (sqlNode.getKind.belongsTo(SqlKind.DDL)
-        || sqlNode.getKind == SqlKind.INSERT) {
+        || sqlNode.getKind == SqlKind.INSERT
+        || sqlNode.getKind == SqlKind.CREATE_FUNCTION
+        || sqlNode.getKind == SqlKind.DROP_FUNCTION) {
 
 Review comment:
   miss ALTER_FUNCTION?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message