From issues-return-200403-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Nov 8 13:56:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 90F0C18067A for ; Thu, 8 Nov 2018 13:56:50 +0100 (CET) Received: (qmail 90720 invoked by uid 500); 8 Nov 2018 12:56:49 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 90711 invoked by uid 99); 8 Nov 2018 12:56:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2018 12:56:49 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] hequn8128 commented on issue #7052: [FLINK-10814][examples] Add scala suffix for Kafka example module Message-ID: <154168180912.26258.13154307322720451007.gitbox@gitbox.apache.org> Date: Thu, 08 Nov 2018 12:56:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hequn8128 commented on issue #7052: [FLINK-10814][examples] Add scala suffix for Kafka example module URL: https://github.com/apache/flink/pull/7052#issuecomment-436984872 Hi @zentol , thanks a lot for your review. Should we add scala suffix to a java module? I find both `flink-examples-streaming-kafka` and `flink-examples-streaming-kafka-base` are java module which contians no scala code, similar to `flink-core`. Best, Hequn ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services