flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10816) Fix LockableTypeSerializer.duplicate()
Date Wed, 07 Nov 2018 17:48:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678567#comment-16678567
] 

ASF GitHub Bot commented on FLINK-10816:
----------------------------------------

zentol commented on a change in pull request #7049: [FLINK-10816][cep] Fix LockableTypeSerializer.duplicate()
to consider…
URL: https://github.com/apache/flink/pull/7049#discussion_r231609118
 
 

 ##########
 File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/Lockable.java
 ##########
 @@ -109,8 +110,10 @@ public boolean isImmutableType() {
 		}
 
 		@Override
-		public TypeSerializer<Lockable<E>> duplicate() {
-			return new LockableTypeSerializer<>(elementSerializer);
+		public LockableTypeSerializer<E> duplicate() {
 
 Review comment:
   why are you changing the signature?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix LockableTypeSerializer.duplicate() 
> ---------------------------------------
>
>                 Key: FLINK-10816
>                 URL: https://issues.apache.org/jira/browse/FLINK-10816
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>    Affects Versions: 1.6.2, 1.7.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>
> {{LockableTypeSerializer.duplicate()}} is not properly implemented and must consider
duplicating the element serializer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message