flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Congxian Qiu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLINK-10794) Do not create checkpointStorage when checkpoint is disabled
Date Mon, 05 Nov 2018 12:12:01 GMT

     [ https://issues.apache.org/jira/browse/FLINK-10794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Congxian Qiu updated FLINK-10794:
---------------------------------
    Description: 
In `StreamTask#invoke` will create CheckpointStore by `stateBackend.createCheckpointStorage`,
and create some directories if needed. but if the checkpoint is disabled, we could skip the
creation of checkpointStore.

 

IMO, the code could change to something like below

 
{code:java}
boolean enabledCheckpoint = "true".equalsIgnoreCase(configuration.getConfiguration().getString("checkpointing",
"false"));
if (enabledCheckpoint) {
   checkpointStorage = stateBackend.createCheckpointStorage(getEnvironment().getJobID());
}
{code}

  was:
In `StreamTask#invoke` will create CheckpointStore by `stateBackend.createCheckpointStorage`,
and create some directories if needed. but if the checkpoint is disabled, the checkpointstore
could never be created. 

 

IMO, the code could change to something like below

`
{code:java}
boolean enabledCheckpoint = "true".equalsIgnoreCase(configuration.getConfiguration().getString("checkpointing",
"false"));
if (enabledCheckpoint) {
   checkpointStorage = stateBackend.createCheckpointStorage(getEnvironment().getJobID());
}
{code}


> Do not create checkpointStorage when checkpoint is disabled
> -----------------------------------------------------------
>
>                 Key: FLINK-10794
>                 URL: https://issues.apache.org/jira/browse/FLINK-10794
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Congxian Qiu
>            Assignee: Congxian Qiu
>            Priority: Major
>
> In `StreamTask#invoke` will create CheckpointStore by `stateBackend.createCheckpointStorage`,
and create some directories if needed. but if the checkpoint is disabled, we could skip the
creation of checkpointStore.
>  
> IMO, the code could change to something like below
>  
> {code:java}
> boolean enabledCheckpoint = "true".equalsIgnoreCase(configuration.getConfiguration().getString("checkpointing",
"false"));
> if (enabledCheckpoint) {
>    checkpointStorage = stateBackend.createCheckpointStorage(getEnvironment().getJobID());
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message