flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink
Date Thu, 08 Nov 2018 16:10:44 GMT
pnowojski commented on a change in pull request #6927: [FLINK-10624] Extend SQL client end-to-end
to test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#discussion_r231950736
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_sql_client_common.sh
 ##########
 @@ -17,8 +17,6 @@
 # limitations under the License.
 ################################################################################
 
-set -Eeuo pipefail
-
 source "$(dirname "$0")"/common.sh
 source "$(dirname "$0")"/kafka-common.sh 0.10.2.0 3.2.0 3.2
 source "$(dirname "$0")"/elasticsearch-common.sh
 
 Review comment:
   Have you forgotten to remove those imports?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message