flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sunjincheng121 commented on a change in pull request #6949: [FLINK-10676][table] Add 'as' method for OverWindowWithOrderBy
Date Wed, 07 Nov 2018 15:20:30 GMT
sunjincheng121 commented on a change in pull request #6949: [FLINK-10676][table] Add 'as' method
for OverWindowWithOrderBy
URL: https://github.com/apache/flink/pull/6949#discussion_r231500525
 
 

 ##########
 File path: docs/dev/table/tableApi.md
 ##########
 @@ -1571,13 +1571,15 @@ The `OverWindow` defines a range of rows over which aggregates are
computed. `Ov
     </tr>
     <tr>
       <td><code>preceding</code></td>
-      <td>Required</td>
+      <td>Optional</td>
       <td>
         <p>Defines the interval of rows that are included in the window and precede
the current row. The interval can either be specified as time or row-count interval.</p>
 
         <p><a href="tableApi.html#bounded-over-windows">Bounded over windows</a>
are specified with the size of the interval, e.g., <code>10.minutes</code> for
a time interval or <code>10.rows</code> for a row-count interval.</p>
 
         <p><a href="tableApi.html#unbounded-over-windows">Unbounded over windows</a>
are specified using a constant, i.e., <code>UNBOUNDED_RANGE</code> for a time
interval or <code>UNBOUNDED_ROW</code> for a row-count interval. Unbounded over
windows start with the first row of a partition.</p>
+        
+        <p>If the <code>preceding</code> and <code>following</code>
clause both are omitted, RANGE UNBOUNDED PRECEDING AND CURRENT ROW is used as default for
window.</p>
 
 Review comment:
   
   UNBOUNDED_RANGE and CURRENT_RANGE appear in pairs´╝îSo the following description is recommended:
   If the preceding clause is omitted, UNBOUNDED_RANGE and CURRENT_RANGE is used as default
for window. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message