flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] bowenli86 commented on issue #7012: [FLINK-10769][Table & SQL] port InMemoryExternalCatalog to java
Date Mon, 05 Nov 2018 16:57:09 GMT
bowenli86 commented on issue #7012: [FLINK-10769][Table & SQL] port InMemoryExternalCatalog
to java
URL: https://github.com/apache/flink/pull/7012#issuecomment-435950340
 
 
   Thanks, @fhueske. Sorry that the description might be a bit imprecise. I updated descriptions
in both the PR and the JIRA ticket. You're right, it's not all code, I'm mainly referring
to external catalog related code, and @twalthr and I have discussed it in [FLINK-10689](https://issues.apache.org/jira/browse/FLINK-10689).
Let me explain here:
   
   Background is that we have two parallel efforts going on right now - FLINK-10686, driven
by Timo, includes moving external catalogs APIs from flink-table to flink-table-common, from
Scala to Java; FLINK-10744 I'm working on right now to integrate Flink with Hive and enhance
external catalog functionality.
   
   As discussed with @twalthr in [FLINK-10689](https://issues.apache.org/jira/browse/FLINK-10689),
we'd better parallelize these efforts while introducing minimal overhead for integrating them
later. An agreed way is to writing new code/feature related to external catalogs/hive in Java
in flink-table first then move to other module like flink-table-common, this way we can minimize
migration efforts. If existing classes are modified for a feature we can start migrating them
to Java in a separate commit first and then perform the actual feature changes, and migrated
classes can be placed in flink-table/src/main/java until we find a better module structure.
   
   Does my explanation here relieve your concerns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message