flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure
Date Mon, 05 Nov 2018 13:13:27 GMT
pnowojski commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to
end test failure
URL: https://github.com/apache/flink/pull/6963#discussion_r230740562
 
 

 ##########
 File path: flink-end-to-end-tests/run-pre-commit-tests.sh
 ##########
 @@ -48,6 +48,7 @@ echo "Flink distribution directory: $FLINK_DIR"
 # those checks are disabled, one should take care that a proper checks are performed in the
tests itself that ensure that the test finished
 # in an expected state.
 
+run_test "SQL Client end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_client.sh" "skip_check_exceptions"
 
 Review comment:
   Quoting @dawidwys:
   > If you don't want to extend the global list, (...) I would disable the log checking**
via #6959 **_AND_ add a custom check in the test itself that verifies logs with your extended
whitelist** (preferably in a trap invoked on exit).
   
   and look two lines above
   ```
   # IMPORTANT:
   # (...) Whenever
   # those checks are disabled, one should take care that a proper checks are performed in
the tests itself that ensure that the test finished
   # in an expected state.
   ```
   
   tbh in this case I would just prefer adding `Error while loading kafka-version.properties
:null` to a global exclusion list, instead of copying whole exclusion list to the kafka test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message