From issues-return-196605-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Oct 22 21:33:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 74022180675 for ; Mon, 22 Oct 2018 21:33:05 +0200 (CEST) Received: (qmail 91030 invoked by uid 500); 22 Oct 2018 19:33:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 91021 invoked by uid 99); 22 Oct 2018 19:33:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 19:33:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E4BC1180B21 for ; Mon, 22 Oct 2018 19:33:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id qc33DgLLntVS for ; Mon, 22 Oct 2018 19:33:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 263275F491 for ; Mon, 22 Oct 2018 19:33:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6CEEAE0F4C for ; Mon, 22 Oct 2018 19:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EC4B6252AB for ; Mon, 22 Oct 2018 19:33:00 +0000 (UTC) Date: Mon, 22 Oct 2018 19:33:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-10637) Start MiniCluster with random REST port MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659534#comment-16659534 ] ASF GitHub Bot commented on FLINK-10637: ---------------------------------------- zentol commented on a change in pull request #6899: [FLINK-10637] Use MiniClusterResource for tests in flink-runtime URL: https://github.com/apache/flink/pull/6899#discussion_r227035131 ########## File path: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala ########## @@ -320,7 +320,7 @@ object ScalaShellITCase { @BeforeClass def beforeAll(): Unit = { // set to different than default so not to interfere with ScalaShellLocalStartupITCase - configuration.setInteger(RestOptions.PORT, 8082) + configuration.setInteger(RestOptions.PORT, 0) Review comment: this could simply be removed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Start MiniCluster with random REST port > --------------------------------------- > > Key: FLINK-10637 > URL: https://issues.apache.org/jira/browse/FLINK-10637 > Project: Flink > Issue Type: Improvement > Components: Tests > Affects Versions: 1.5.4, 1.6.1, 1.7.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Critical > Labels: pull-request-available > Fix For: 1.5.6, 1.6.3, 1.7.0 > > > The {{MiniCluster}} picks a random port for the {{RpcService}} but not for the REST server endpoint. Due to this it falls back to {{8081}}. This can lead to port conflicts if tests are executed concurrently. > I propose to rename the {{MiniClusterResource}} into {{MiniClusterResourceWithRestClient}} and add a new {{MiniClusterResource}} which only starts a {{MiniCluster}} with the REST port set to 0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)