From issues-return-193171-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Oct 9 14:32:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AAF05180668 for ; Tue, 9 Oct 2018 14:32:03 +0200 (CEST) Received: (qmail 48498 invoked by uid 500); 9 Oct 2018 12:32:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 48489 invoked by uid 99); 9 Oct 2018 12:32:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 12:32:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 47699C1E02 for ; Tue, 9 Oct 2018 12:32:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ZSkeuP8vevJn for ; Tue, 9 Oct 2018 12:32:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 57D175F385 for ; Tue, 9 Oct 2018 12:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C4DD6E25B2 for ; Tue, 9 Oct 2018 12:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5351224811 for ; Tue, 9 Oct 2018 12:32:00 +0000 (UTC) Date: Tue, 9 Oct 2018 12:32:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-10465) Jepsen: runit supervised sshd is stopped on tear down MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643265#comment-16643265 ] ASF GitHub Bot commented on FLINK-10465: ---------------------------------------- GJL closed pull request #6779: [FLINK-10465][tests] Do not stop sshd if it is supervised by runit. URL: https://github.com/apache/flink/pull/6779 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/flink-jepsen/src/jepsen/flink/utils.clj b/flink-jepsen/src/jepsen/flink/utils.clj index 50d0075ca35..5f96f8c00b7 100644 --- a/flink-jepsen/src/jepsen/flink/utils.clj +++ b/flink-jepsen/src/jepsen/flink/utils.clj @@ -86,4 +86,7 @@ [] (info "Stop all supervised services.") (c/su - (c/exec :rm :-f (c/lit (str "/etc/service/*"))))) + ;; HACK: + ;; Remove all symlinks in /etc/service except sshd. + ;; This is only relevant when tests are run in Docker because there sshd is started using runit. + (c/exec :find (c/lit (str "/etc/service -maxdepth 1 -type l ! -name 'sshd' -delete"))))) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Jepsen: runit supervised sshd is stopped on tear down > ----------------------------------------------------- > > Key: FLINK-10465 > URL: https://issues.apache.org/jira/browse/FLINK-10465 > Project: Flink > Issue Type: Bug > Components: Tests > Affects Versions: 1.7.0, 1.6.2 > Reporter: Gary Yao > Assignee: Gary Yao > Priority: Critical > Labels: pull-request-available > Fix For: 1.7.0, 1.6.2 > > > When tearing down the _DB_, we tear down all services supervised by runit. However when running the tests in Docker, sshd is under supervision by runit. When sshd is stopped, the tests cannot be continued because the control node cannot interact with the DB nodes anymore. > *How to reproduce* > Run command below in control-node container: > {code} > ./docker/run-tests.sh 1 [...]/flink/flink-1.6.1/flink-1.6.1-bin-hadoop28-scala_2.11.tgz > {code} > *Expected behavior* > sshd should never be stopped -- This message was sent by Atlassian JIRA (v7.6.3#76005)