From issues-return-196322-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Oct 22 05:34:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6CEA4180674 for ; Mon, 22 Oct 2018 05:34:05 +0200 (CEST) Received: (qmail 94766 invoked by uid 500); 22 Oct 2018 03:34:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 94757 invoked by uid 99); 22 Oct 2018 03:34:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 03:34:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D7920C0410 for ; Mon, 22 Oct 2018 03:34:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tiZzF5-N1QPi for ; Mon, 22 Oct 2018 03:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 446215F530 for ; Mon, 22 Oct 2018 03:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74C46E0177 for ; Mon, 22 Oct 2018 03:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 39B0625298 for ; Mon, 22 Oct 2018 03:34:00 +0000 (UTC) Date: Mon, 22 Oct 2018 03:34:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-10205?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166= 58516#comment-16658516 ]=20 ASF GitHub Bot commented on FLINK-10205: ---------------------------------------- isunjin commented on issue #6684: [FLINK-10205] Batch Job: InputSplit F= ault tolerant for DataSource=E2=80=A6 URL: https://github.com/apache/flink/pull/6684#issuecomment-431734239 =20 =20 Great discussion, thanks everybody.=20 @wenlong88, the scenario you mention is what i try to fix. [here](https= ://github.com/isunjin/flink/commit/b61b58d963ea11d34e2eb7ec6f4fe4bfed4dca4a= ) is a concrete example, a simple word count job will have data inconsisten= t while failover, the job should fail but success with zero output. =20 @tillrohrmann, **_InputSplitAssigner_** generate a list of _**InputSplit= **_, the order might not matter, but every input should be proceed exactly = once, if a task fail while process a _**InputSplit**_, this _**InputSplit**= _ should be processed again, however, in batch scenario, it might not true,= [this](https://github.com/isunjin/flink/commit/b61b58d963ea11d34e2eb7ec6f= 4fe4bfed4dca4a) repro shows that the current codebase doesn't has this logi= c and thus it has data inconsistent issue. =20 Its not a problem in Streaming scenario, as the _**InputSplit**_ will b= e treat as a record, eg: in _**ContinuousFileMonitoringFunction**_, it will= collect _**InputSplit**_ and every _**InputSplit**_ will be guaranteed p= rocess exactly once by FLINK, @wenlong88 will this work in your scenario?= =20 =20 =20 =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Batch Job: InputSplit Fault tolerant for DataSourceTask > ------------------------------------------------------- > > Key: FLINK-10205 > URL: https://issues.apache.org/jira/browse/FLINK-10205 > Project: Flink > Issue Type: Sub-task > Components: JobManager > Affects Versions: 1.6.1, 1.6.2, 1.7.0 > Reporter: JIN SUN > Assignee: JIN SUN > Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > Original Estimate: 168h > Remaining Estimate: 168h > > Today DataSource Task pull InputSplits from JobManager to achieve better = performance, however, when a DataSourceTask failed and rerun, it will not g= et the same splits as its previous version. this will introduce inconsisten= t result or even data corruption. > Furthermore,=C2=A0 if there are two executions run at the same time (in b= atch scenario), this two executions should process same splits. > we need to fix the issue to make the inputs of a DataSourceTask determini= stic. The propose is save all splits into ExecutionVertex and DataSourceTas= k will pull split from there. > =C2=A0document: > [https://docs.google.com/document/d/1FdZdcA63tPUEewcCimTFy9Iz2jlVlMRANZkO= 4RngIuk/edit?usp=3Dsharing] -- This message was sent by Atlassian JIRA (v7.6.3#76005)