From issues-return-192378-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Oct 4 15:53:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 62E3D180677 for ; Thu, 4 Oct 2018 15:53:04 +0200 (CEST) Received: (qmail 11288 invoked by uid 500); 4 Oct 2018 13:53:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 11279 invoked by uid 99); 4 Oct 2018 13:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Oct 2018 13:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F241AC97E7 for ; Thu, 4 Oct 2018 13:53:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PvTM06tj47ZB for ; Thu, 4 Oct 2018 13:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 39BB35F3F2 for ; Thu, 4 Oct 2018 13:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76184E0F4C for ; Thu, 4 Oct 2018 13:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 50D482472B for ; Thu, 4 Oct 2018 13:53:00 +0000 (UTC) Date: Thu, 4 Oct 2018 13:53:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9997) Improve Expression Reduce MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638253#comment-16638253 ] ASF GitHub Bot commented on FLINK-9997: --------------------------------------- Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce URL: https://github.com/apache/flink/pull/6455#discussion_r222677511 ########## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/ExpressionReductionRulesTest.scala ########## @@ -477,6 +476,22 @@ class ExpressionReductionRulesTest extends TableTestBase { util.verifyTable(result, expected) } + @Test + def testReduceDeterministicUDFInBatch(): Unit = { + val util = batchTestUtil() + val table = util.addTable[(Int, Long, String)]("MyTable", 'a, 'b, 'c) + + // if isDeterministic = true, will cause a Calcite NPE, which will be fixed in [CALCITE-1860] Review comment: This comment can be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Improve Expression Reduce > ------------------------- > > Key: FLINK-9997 > URL: https://issues.apache.org/jira/browse/FLINK-9997 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Ruidong Li > Assignee: Ruidong Li > Priority: Major > Labels: pull-request-available > > There's no Calc node at normalize plans, so ReduceExpressionRule.CALC does not match any thing. > If adding calc-related rules to normalize phase, then project-related rules and filter-related rules do not match any thing at logical opt phase. If adding ReduceExpressionRule.CALC to logical opt phase, it will increase the the search time. Therefore, adding a new phase after logical opt may be an option. -- This message was sent by Atlassian JIRA (v7.6.3#76005)