From issues-return-194880-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Oct 16 15:03:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0E3D6180674 for ; Tue, 16 Oct 2018 15:03:51 +0200 (CEST) Received: (qmail 34302 invoked by uid 500); 16 Oct 2018 13:03:51 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 34293 invoked by uid 99); 16 Oct 2018 13:03:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 13:03:51 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] Port JobManagerFailsITCase to new code base Message-ID: <153969503059.20173.1003293407505538084.gitbox@gitbox.apache.org> Date: Tue, 16 Oct 2018 13:03:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] Port JobManagerFailsITCase to new code base URL: https://github.com/apache/flink/pull/6841#discussion_r225528980 ########## File path: flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java ########## @@ -325,6 +325,21 @@ public void run() { dispatcherProcesses[1] = new DispatcherProcess(1, config); dispatcherProcesses[1].startProcess(); + // get new dispatcher gateway + leaderListener.waitForNewLeader(deadline.timeLeft().toMillis()); + + leaderAddress = leaderListener.getAddress(); + leaderId = leaderListener.getLeaderSessionID(); + + final CompletableFuture newDispatcherGatewayFuture = rpcService.connect( + leaderAddress, + DispatcherId.fromUuid(leaderId), + DispatcherGateway.class); + final DispatcherGateway newDispatcherGateway = newDispatcherGatewayFuture.get(); + + // Wait for all task managers to connect to the new leading job manager + waitForTaskManagers(numberOfTaskManagers, newDispatcherGateway, deadline.timeLeft()); Review comment: Yes, I would be in favour of this @TisonKun. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services