From issues-return-194057-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Oct 12 11:49:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 056E018067A for ; Fri, 12 Oct 2018 11:49:10 +0200 (CEST) Received: (qmail 7310 invoked by uid 500); 12 Oct 2018 09:49:10 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 7301 invoked by uid 99); 12 Oct 2018 09:49:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2018 09:49:10 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 Message-ID: <153933774956.7236.9191303409750088944.gitbox@gitbox.apache.org> Date: Fri, 12 Oct 2018 09:49:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224731424 ########## File path: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaProducerTestBase.java ########## @@ -204,15 +204,15 @@ public void cancel() { */ @Test public void testOneToOneAtLeastOnceRegularSink() throws Exception { - testOneToOneAtLeastOnce(true); + //testOneToOneAtLeastOnce(true); Review comment: You mean make them enable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services