From issues-return-193421-archive-asf-public=cust-asf.ponee.io@flink.apache.org Wed Oct 10 09:25:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E454218067A for ; Wed, 10 Oct 2018 09:25:34 +0200 (CEST) Received: (qmail 18457 invoked by uid 500); 10 Oct 2018 07:25:33 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 18447 invoked by uid 99); 10 Oct 2018 07:25:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Oct 2018 07:25:33 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] aljoscha removed a comment on issue #6784: [FLINK-7811] Add support for Scala 2.12 Message-ID: <153915633313.20284.6408513479981072770.gitbox@gitbox.apache.org> Date: Wed, 10 Oct 2018 07:25:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit aljoscha removed a comment on issue #6784: [FLINK-7811] Add support for Scala 2.12 URL: https://github.com/apache/flink/pull/6784#issuecomment-428466231 @tzulitai Could you please have a look at the Consumer and Producer constructors to see which ones we'd like to keep? I remember that quite a few of the constructors we have in the older consumers are deprecated and I want to make sure that we only have the good ones here. @yanghua The internals code (and most of the code in general) you were able to copy from the other connectors, correct? What did you have to adapt to make it work for Kafka 2.0? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services