From issues-return-192830-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Oct 8 14:40:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3E5C918072F for ; Mon, 8 Oct 2018 14:40:50 +0200 (CEST) Received: (qmail 85960 invoked by uid 500); 8 Oct 2018 12:40:49 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 85946 invoked by uid 99); 8 Oct 2018 12:40:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2018 12:40:49 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty Message-ID: <153900244875.21137.9592546450121565010.gitbox@gitbox.apache.org> Date: Mon, 08 Oct 2018 12:40:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r221851878 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java ########## @@ -97,6 +107,18 @@ public void run() { }); } + void registerPeriodicFlush(NetworkSequenceViewReader reader, long flushTimeout) { + if (flushTimeout == 0) { + return; + } + ctx.executor().execute(new Runnable() { + @Override + public void run() { + ctx.pipeline().fireUserEventTriggered(new RegisterPeriodicFlushEvent(reader, flushTimeout)); + } + }); Review comment: use a lambda function instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services