flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10687) Make flink-formats Scala-free
Date Mon, 29 Oct 2018 12:39:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667135#comment-16667135
] 

ASF GitHub Bot commented on FLINK-10687:
----------------------------------------

twalthr commented on a change in pull request #6958: [FLINK-10687] [table] Make flink-formats
Scala-free
URL: https://github.com/apache/flink/pull/6958#discussion_r228907041
 
 

 ##########
 File path: flink-formats/flink-avro/pom.xml
 ##########
 @@ -64,16 +64,30 @@ under the License.
 
 		<dependency>
 			<groupId>org.apache.flink</groupId>
-			<!-- use a dedicated Scala version to not depend on it -->
-			<artifactId>flink-table_2.11</artifactId>
+			<artifactId>flink-table-common</artifactId>
 			<version>${project.version}</version>
 			<scope>provided</scope>
-			<!-- Projects depending on this project, won't depend on flink-table. -->
-			<optional>true</optional>
 		</dependency>
 
 		<!-- test dependencies -->
 
+		<dependency>
 
 Review comment:
   This dependency is necessary for `org.apache.flink.table.descriptors.AvroTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make flink-formats Scala-free
> -----------------------------
>
>                 Key: FLINK-10687
>                 URL: https://issues.apache.org/jira/browse/FLINK-10687
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> {{flink-table}} is the only dependency that pulls in Scala for {{flink-json}}, {{flink-avro}}.
We should aim to make {{flink-formats}} Scala-free using only a dependency to {{flink-table-common}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message