flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10687) Make flink-formats Scala-free
Date Mon, 29 Oct 2018 12:33:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667127#comment-16667127
] 

ASF GitHub Bot commented on FLINK-10687:
----------------------------------------

twalthr commented on a change in pull request #6958: [FLINK-10687] [table] Make flink-formats
Scala-free
URL: https://github.com/apache/flink/pull/6958#discussion_r228905508
 
 

 ##########
 File path: flink-libraries/flink-table-common/pom.xml
 ##########
 @@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+	<modelVersion>4.0.0</modelVersion>
+
+	<parent>
+		<groupId>org.apache.flink</groupId>
+		<artifactId>flink-libraries</artifactId>
+		<version>1.7-SNAPSHOT</version>
+		<relativePath>..</relativePath>
+	</parent>
+
+	<artifactId>flink-table-common</artifactId>
+	<name>flink-table-common</name>
+
+	<packaging>jar</packaging>
+
+	<dependencies>
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-core</artifactId>
+			<version>1.7-SNAPSHOT</version>
+		</dependency>
+	</dependencies>
+
+	<build>
 
 Review comment:
   Yes, maybe not that much right now but in the future. Currently, other modules can use
`org.apache.flink.table.descriptors.DescriptorTestBase`. In the future it is likely that more
classes will be added as `flink-table-common` is intended to be shared across modules.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make flink-formats Scala-free
> -----------------------------
>
>                 Key: FLINK-10687
>                 URL: https://issues.apache.org/jira/browse/FLINK-10687
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> {{flink-table}} is the only dependency that pulls in Scala for {{flink-json}}, {{flink-avro}}.
We should aim to make {{flink-formats}} Scala-free using only a dependency to {{flink-table-common}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message