flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10623) Extend streaming SQL end-to-end test to test MATCH_RECOGNIZE
Date Fri, 26 Oct 2018 15:11:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665281#comment-16665281
] 

ASF GitHub Bot commented on FLINK-10623:
----------------------------------------

pnowojski commented on a change in pull request #6926:  [FLINK-10623][e2e] Extended sql-client
e2e test with MATCH_RECOGNIZE 
URL: https://github.com/apache/flink/pull/6926#discussion_r228564019
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamMatchRule.scala
 ##########
 @@ -42,11 +42,13 @@ class DataStreamMatchRule
       RelOptRule.convert(logicalMatch.getInput, FlinkConventions.DATASTREAM)
 
     try {
-      Class.forName("org.apache.flink.cep.pattern.Pattern")
+      Class
+        .forName("org.apache.flink.cep.pattern.Pattern",
+          false,
+          Thread.currentThread().getContextClassLoader)
     } catch {
       case ex: ClassNotFoundException => throw new TableException(
-        "MATCH RECOGNIZE clause requires flink-cep dependency to be present on the classpath.",
-        ex)
+        "MATCH RECOGNIZE clause requires flink-cep dependency to be present on the classpath.")
 
 Review comment:
   re 2: We know what has happened but I think that `ClassNotFoundException` can have multiple
different causes. One of the is that class was indeed not found, but I think it can also be
thrown if class was found, but JVM was failed to load/initialize it. Hiding this kind of things
might make debugging/troubleshooting impossible/more difficult.  
   
   re 1: if that's the case, I would be inclined to change it at some point of time. Maybe
log causes in sql client to a file or provide `verbose` mode. I'm not saying to do it now,
but decision to ignore/hide the exception cause shouldn't be made at this level anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Extend streaming SQL end-to-end test to test MATCH_RECOGNIZE
> ------------------------------------------------------------
>
>                 Key: FLINK-10623
>                 URL: https://issues.apache.org/jira/browse/FLINK-10623
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL, Tests
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> We should extend the existing {{test_streaming_sql.sh}} to test the newly added {{MATCH_RECOGNIZE}}
functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message